Modification to allow multiple pagination objects on same page #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gination elements on the same page. The call to the paginator object to return a page object now accepts an extra `page_param` argument. This argument determines which query parameter is used in the querystring generation, allowing for multiple pagination objects on a single page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
pageparameter produces conflicts when you have multiple pagination objects on the same page.This patch provides an extra keyword argument to the Page object initialization and the
paginator.page()call allowing you to customize the name of the query parameter used for generating the querystring within the page object.All fo the tests pass, and this should not cause any backwards compatibility problems since the new argument is optional.